i#1551 Port DynamoRIO to ARM: split arch/proc.c

i#1551 Port DynamoRIO to ARM: split arch/proc.c
- move core/arch/proc.c to core/arch/x86/proc.c
- extract common code from proc.c to core/arch/proc_shared.c
- add core/arch/arm/proc.c

R=bruening@google.com
BUG=1551

Committed: https://code.google.com/p/dynamorio/source/detail?r=3024

[bruening, 2014-11-25 04:11:18]

didn't have time to finish but had comments on first few files

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c
File core/arch/arm/proc.c (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:87: * DynamoRIO does NOT save the application's
floating-point, MMX, or SSE state
MMX and SSE on ARM?

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:93: * return number of bytes written
I would suggest not duplicating large comments.  Having the comment only in the
.h is one way to do that.

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:96: * we can try to support it in the future.
Comment does not apply

https://codereview.appspot.com/180200043/diff/20001/core/arch/proc.h
File core/arch/proc.h (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/proc.h#newcode260
core/arch/proc.h:260: /* information of a processor */
s/of/about/

[bruening, 2014-11-26 16:54:01]

LGTM if the comments/suggestions are addressed -- shouldn't need another review

https://codereview.appspot.com/180200043/diff/20001/core/arch/x86/proc.c
File core/arch/x86/proc.c (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/x86/proc.c#newc...
core/arch/x86/proc.c:134: case 0x06: cpu_info.L1_icache_size = CACHE_SIZE_8_KB;
break;
Perhaps while you're tweaking the history, un-indent these to match the official
style

[zhaoqin, 2014-11-26 17:02:12]

forget to upload yesterday.

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c
File core/arch/arm/proc.c (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:87: * DynamoRIO does NOT save the application's
floating-point, MMX, or SSE state
On 2014/11/25 04:11:18, bruening wrote:
> MMX and SSE on ARM?

Done.

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:93: * return number of bytes written
On 2014/11/25 04:11:18, bruening wrote:
> I would suggest not duplicating large comments.  Having the comment only in
the
> .h is one way to do that.

Done.

https://codereview.appspot.com/180200043/diff/20001/core/arch/arm/proc.c#newc...
core/arch/arm/proc.c:96: * we can try to support it in the future.
On 2014/11/25 04:11:18, bruening wrote:
> Comment does not apply

Done.

https://codereview.appspot.com/180200043/diff/20001/core/arch/proc.h
File core/arch/proc.h (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/proc.h#newcode260
core/arch/proc.h:260: /* information of a processor */
On 2014/11/25 04:11:18, bruening wrote:
> s/of/about/

Done.

https://codereview.appspot.com/180200043/diff/20001/core/arch/x86/proc.c
File core/arch/x86/proc.c (right):

https://codereview.appspot.com/180200043/diff/20001/core/arch/x86/proc.c#newc...
core/arch/x86/proc.c:134: case 0x06: cpu_info.L1_icache_size = CACHE_SIZE_8_KB;
break;
On 2014/11/26 16:54:01, bruening wrote:
> Perhaps while you're tweaking the history, un-indent these to match the
official
> style

Done.

[zhaoqin, 2014-11-26 18:17:48]

Committed patchset #3 (id:40001) manually as 3024 (presubmit successful).