src/cmd/gc/subr.c - Issue 180092: gc: method expressions on concrete types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/subr.c

Issue 180092: gc: method expressions on concrete types (Closed)

Patch Set: code review 180092: gc: method expressions on concrete types Created 15 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/subr.c

===================================================================

--- a/src/cmd/gc/subr.c

+++ b/src/cmd/gc/subr.c

@@ -2531,7 +2531,7 @@

Sym *s;

int c, d;

- typecheck(&n->left, Erv);

+ typecheck(&n->left, Etype|Erv);

t = n->left->type;

if(t == T)

goto ret;

@@ -2913,7 +2913,7 @@

// if pointer receiver in method,

// the method does not exist for value types.

rcvr = getthisx(tm->type)->type->type;

- if(isptr[rcvr->etype] && !isptr[t0->etype] && !followptr && !isifacemethod(tm)) {

+ if(isptr[rcvr->etype] && !isptr[t0->etype] && !followptr && !isifacemethod(tm->type)) {

if(debug['r'])

yyerror("interface pointer mismatch");

*m = im;

« no previous file with comments | « src/cmd/gc/reflect.c ('k') | src/cmd/gc/typecheck.c » ('j') | no next file with comments »