code review 180061: add the ability to invoke niladic single-valued methods...

add the ability to invoke niladic single-valued methods in templates.
Fixes issue 389.

[r, 2009-12-16 06:45:16]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-12-16 07:16:36]

LGTM

http://codereview.appspot.com/180061/diff/7/1001
File src/pkg/template/template.go (right):

http://codereview.appspot.com/180061/diff/7/1001#newcode26
src/pkg/template/template.go:26: (structs only) (result = data.field())
why structs only?

http://codereview.appspot.com/180061/diff/7/1001#newcode629
src/pkg/template/template.go:629: data =
data.(*reflect.StructValue).FieldByIndex(field.Index)
a
continue
.

and in case MapType

and then the callMethod can be the last ditch effort
for any type

http://codereview.appspot.com/180061/diff/7/1001#newcode647
src/pkg/template/template.go:647: // see if we can find the method at each step.
a
// Most steps will see NumMethod() == 0.
.

http://codereview.appspot.com/180061/diff/7/1001#newcode652
src/pkg/template/template.go:652: if typ.Method(i).Name == name {
m := typ.Method(i);
worth factoring out that call
(3x)

[r, 2009-12-16 11:10:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=b0524afd0d7c ***

add the ability to invoke niladic single-valued methods in templates.
Fixes issue 389.

R=rsc
CC=golang-dev
http://codereview.appspot.com/180061