Issue 180046: code review 180046: math: faster, easier to inline IsNaN, IsInf

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180046: code review 180046: math: faster, easier to inline IsNaN, IsInf (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

math: faster, easier to inline IsNaN, IsInf

Patch Set 2 : code review 180046: math: faster, easier to inline IsNaN, IsInf #

Patch Set 3 : code review 180046: math: faster, easier to inline IsNaN, IsInf #

Total comments: 1

Patch Set 4 : code review 180046: math: faster, easier to inline IsNaN, IsInf #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	src/pkg/math/bits.go	View	1 2 3	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 3 months ago (2009-12-16 01:03:48 UTC) #1

LGTM fix typo http://codereview.appspot.com/180046/diff/1004/1005 File src/pkg/math/bits.go (right): http://codereview.appspot.com/180046/diff/1004/1005#newcode44 src/pkg/math/bits.go:44: // Test for infinity by comparing ...

15 years, 3 months ago (2009-12-16 01:05:44 UTC) #2

rsc

15 years, 3 months ago (2009-12-16 01:21:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3a009c7db720 ***

math: faster, easier to inline IsNaN, IsInf

R=r
CC=golang-dev
http://codereview.appspot.com/180046

Expand All Messages | Collapse All Messages