Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(528)

Issue 180044: code review 180044: Tweak test to work with both 6g and gccgo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by iant
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc
Visibility:
Public.

Description

Tweak test to work with both 6g and gccgo. Pull the struct into a single line, since 6g reports the error on the last line of the struct definition and gccgo reports it on the first line. 6g: bug215.go:12: invalid recursive type A gccgo: bug215.go:12:6: error: invalid recursive type ‘A’

Patch Set 1 #

Patch Set 2 : code review 180044: Tweak test to work with both 6g and gccgo. #

Patch Set 3 : code review 180044: Tweak test to work with both 6g and gccgo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M test/fixedbugs/bug215.go View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc, I'd like you to review the following change.
15 years, 3 months ago (2009-12-15 21:23:35 UTC) #1
rsc
LGTM On Tue, Dec 15, 2009 at 13:23, <iant@golang.org> wrote: > Reviewers: rsc, > > ...
15 years, 3 months ago (2009-12-15 21:27:03 UTC) #2
iant
15 years, 3 months ago (2009-12-15 21:57:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bda832f39ded ***

Tweak test to work with both 6g and gccgo.

Pull the struct into a single line, since 6g reports the error
on the last line of the struct definition and gccgo reports it
on the first line.

6g:
bug215.go:12: invalid recursive type A

gccgo:
bug215.go:12:6: error: invalid recursive type ‘A’

R=rsc
http://codereview.appspot.com/180044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b