code review 179540043: encoding/xml: respect name spaces when encoding

src/encoding/xml/read_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package xml
 
 import (
+        "bytes"
+        "fmt"
         "io"
         "reflect"
         "strings"
         "testing"
         "time"
 )
 
 // Stripped down Atom feed data structures.
 
 func TestUnmarshalFeed(t *testing.T) {
@@ skipping 459 matching lines @@
                         t.Errorf("#%d: Unmarshal: %v", i, err)
                         continue
                 }
                 want := tt.tab
                 if dst != want {
                         t.Errorf("#%d: dst=%+v, want %+v", i, dst, want)
                 }
         }
 }
 
+func TestMarshalUnmarshalRoundTrip(t *testing.T) {
+        // From issue 7535
+        source := `<ex:element xmlns:ex="http://example.com/schema"></ex:element>`
+        in := bytes.NewBufferString(source)
+        for i := 0; i < 10; i++ {
+                out := &bytes.Buffer{}
+                d := NewDecoder(in)
+                e := NewEncoder(out)
+
+                for {
+                        t, err := d.Token()
+                        if err == io.EOF {
+                                break
+                        }
+                        if err != nil {
+                                fmt.Println("failed:", err)
+                                return
+                        }
+                        e.EncodeToken(t)
+                }
+                e.Flush()
+                in = out
+        }
+        if in.String() != source {
+                t.Errorf("have %s; want %s", in.String(), source)
+        }
+}
+
 func TestMarshalNS(t *testing.T) {
         dst := Tables{"hello", "world"}
         data, err := Marshal(&dst)
         if err != nil {
                 t.Fatalf("Marshal: %v", err)
         }
         want := `<Tables><table xmlns="http://www.w3.org/TR/html4/">hello</table><table xmlns="http://www.w3schools.com/furniture">world</table></Tables>`
         str := string(data)
         if str != want {
                 t.Errorf("have: %q\nwant: %q\n", str, want)
@@ skipping 103 matching lines @@
                 }
         }
 }
 
 func TestMarshalNSAttr(t *testing.T) {
         src := TableAttrs{TAttr{"hello", "world", "en_US", "other1", "other2", "other3", "other4"}}
         data, err := Marshal(&src)
         if err != nil {
                 t.Fatalf("Marshal: %v", err)
         }
-        want := `<TableAttrs><TAttr xmlns:html4="http://www.w3.org/TR/html4/" html4:table="hello" xmlns:furniture="http://www.w3schools.com/furniture" furniture:table="world" xml:lang="en_US" xmlns:_xml="http://golang.org/xml/" _xml:other="other1" xmlns:_xmlfoo="http://golang.org/xmlfoo/" _xmlfoo:other="other2" xmlns:json="http://golang.org/json/" json:other="other3" xmlns:json_1="http://golang.org/2/json/" json_1:other="other4"></TAttr></TableAttrs>`
+        want := `<TableAttrs><TAttr xmlns:json_1="http://golang.org/2/json/" xmlns:json="http://golang.org/json/" xmlns:_xmlfoo="http://golang.org/xmlfoo/" xmlns:_xml="http://golang.org/xml/" xmlns:furniture="http://www.w3schools.com/furniture" xmlns:html4="http://www.w3.org/TR/html4/" html4:table="hello" furniture:table="world" xml:lang="en_US" _xml:other="other1" _xmlfoo:other="other2" json:other="other3" json_1:other="other4"></TAttr></TableAttrs>`
         str := string(data)
         if str != want {
                 t.Errorf("Marshal:\nhave: %#q\nwant: %#q\n", str, want)
         }
 
         var dst TableAttrs
         if err := Unmarshal(data, &dst); err != nil {
                 t.Errorf("Unmarshal: %v", err)
         }
 
@@ skipping 84 matching lines @@
         }
         pea, ok := pod.Pea.(*Pea)
         if !ok {
                 t.Fatalf("unmarshalled into wrong type: have %T want *Pea", pod.Pea)
         }
         have, want := pea.Cotelydon, "Green stuff"
         if have != want {
                 t.Errorf("failed to unmarshal into interface, have %q want %q", have, want)
         }
 }