Hello Greg, I have 7 libraries to publish from the gwt-google-apis library - this is ...
15 years, 7 months ago
(2010-07-09 18:44:20 UTC)
#1
Hello Greg,
I have 7 libraries to publish from the gwt-google-apis library - this is the
first (and other libraries depend on it). They have been published before in
the maven central repository by an end user, so I copied the setup they used. I
hope there is no conflict.
looks good except for path noted below http://codereview.appspot.com/1793041/diff/1/9 File com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom (right): http://codereview.appspot.com/1793041/diff/1/9#newcode15 com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom:15: <groupId>com.google.gwt.gwt-google-apis</groupId> Make ...
15 years, 7 months ago
(2010-07-09 20:10:59 UTC)
#2
looks good except for path noted below
http://codereview.appspot.com/1793041/diff/1/9
File
com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom
(right):
http://codereview.appspot.com/1793041/diff/1/9#newcode15
com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom:15:
<groupId>com.google.gwt.gwt-google-apis</groupId>
Make sure this path matches the path com.google.gwt.google-apis in existing
apache repo for consistency
http://codereview.appspot.com/1793041/diff/1/9 File com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom (right): http://codereview.appspot.com/1793041/diff/1/9#newcode15 com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom:15: <groupId>com.google.gwt.gwt-google-apis</groupId> On 2010/07/09 20:10:59, drfibonacci wrote: > Make sure ...
15 years, 7 months ago
(2010-07-09 20:18:28 UTC)
#3
http://codereview.appspot.com/1793041/diff/1/9
File
com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom
(right):
http://codereview.appspot.com/1793041/diff/1/9#newcode15
com/google/gwt/gwt-google-apis/gwt-ajaxloader/1.1.0/gwt-ajaxloader-1.1.0.pom:15:
<groupId>com.google.gwt.gwt-google-apis</groupId>
On 2010/07/09 20:10:59, drfibonacci wrote:
> Make sure this path matches the path com.google.gwt.google-apis in existing
> apache repo for consistency
Done.
One question I have about this is the GWT dependency. In order to use this ...
15 years, 7 months ago
(2010-07-12 15:27:34 UTC)
#4
One question I have about this is the GWT dependency. In order to use this
library, you need gwt-user and gwt-dev 2.0.3 or higher. But I'm afraid if I
encode the GWT version here it will interfere with the version that the top
level project setting if they want to use something else. I'm just not sure how
that's supposed to work.
Issue 1793041: Adds gwt-ajaxloader 1.1.0 release (from code.google.com/p/gwt-google-apis)
(Closed)
Created 15 years, 7 months ago by zundel
Modified 14 years, 5 months ago
Reviewers: gak, drfibonacci
Base URL: http://google-maven-repository.googlecode.com/svn/repository/
Comments: 2