Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 179129: code review 179129: fix up %p (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by r
Modified:
13 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fix up %p - use an interface {Get()} - implement Get for maps, slices - for slices, retrieves the address of the end of the array, which will give the same value for every slice of the same array.

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 179129: fix up %p #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M src/pkg/fmt/print.go View 2 chunks +7 lines, -4 lines 0 comments Download
M src/pkg/reflect/value.go View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
13 years, 1 month ago (2009-12-22 20:20:04 UTC) #1
rsc
LGTM http://codereview.appspot.com/179129/diff/1/3 File src/pkg/reflect/value.go (right): http://codereview.appspot.com/179129/diff/1/3#newcode570 src/pkg/reflect/value.go:570: // Get returns the uintptr value of v.At(v.Cap()). ...
13 years, 1 month ago (2009-12-22 20:27:58 UTC) #2
r
13 years, 1 month ago (2009-12-22 20:34:33 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=fd3a19c6466c ***

fix up %p
- use an interface {Get()}
- implement Get for maps, slices
- for slices, retrieves the address of the end of the array, which will give the
	same value for every slice of the same array.

R=rsc
CC=golang-dev
http://codereview.appspot.com/179129
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b