Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(323)

Issue 179103: Use root user for create/delete default properties in account chart creation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 5 months ago by ced1
Modified:
16 years, 5 months ago
Reviewers:
bch, udono, yangoon1
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M account.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
ced1
16 years, 5 months ago (2009-12-18 12:47:36 UTC) #1
udono
looks good.
16 years, 5 months ago (2009-12-18 13:52:34 UTC) #2
yangoon1
I don't understand why this change is needed. Could you give a little hint please?
16 years, 5 months ago (2009-12-18 14:00:00 UTC) #3
ced1
On 2009/12/18 14:00:00, yangoon wrote: > I don't understand why this change is needed. Could ...
16 years, 5 months ago (2009-12-18 14:49:02 UTC) #4
bch
On 2009/12/18 14:49:02, ced wrote: > On 2009/12/18 14:00:00, yangoon wrote: > > I don't ...
16 years, 5 months ago (2009-12-18 16:54:38 UTC) #5
ced1
16 years, 5 months ago (2009-12-18 17:34:11 UTC) #6
On 2009/12/18 16:54:38, bch wrote:
> On 2009/12/18 14:49:02, ced wrote:
> > On 2009/12/18 14:00:00, yangoon wrote:
> > > I don't understand why this change is needed. Could you give a little hint
> > > please?
> > 
> > If you are not in the Administration group, you can not create the default
> > properties for account_receivable and account_payable
> 
> Are the access restriction needed on properties? because there are already
> access control on the models targeted by the property field.

It is done on set/get method not on create/write/delete.
So the current access control seems correct for me as normally user must not
access to ir.property directly.
By the way, it will be good to add some ModelSingleton to be able to update some
properties without admin right like the default account receivable/payable.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b