Move decorators and responses to their own files.

Move decorators and responses to their own files.

R=maruel@chromium.org
BUG=

[iannucci, 2013-10-27 12:53:39]

PTAL

[M-A, 2013-10-28 15:41:54]

I know guido preferred one big fat file but I also prefer some segmentation when
the file is >3000k lines.

Some changes first.

https://codereview.appspot.com/17910043/diff/1/codereview/decorators.py
File codereview/decorators.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/decorators.py#newco...
codereview/decorators.py:30: def require_method(*methods):
One thing that would be nice is to keep all them in alphabetic order. It makes
searching for one item easier. wdyt?

https://codereview.appspot.com/17910043/diff/1/codereview/decorators.py#newco...
codereview/decorators.py:351: 
fix spacing everywhere.

https://codereview.appspot.com/17910043/diff/1/codereview/responses.py
File codereview/responses.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/responses.py#newcode38
codereview/responses.py:38: # Counter displayed (by respond()) below) on every
page showing how
Global at top

https://codereview.appspot.com/17910043/diff/1/codereview/responses.py#newcode57
codereview/responses.py:57: global COUNTER
This code is not threadsafe. I don't know if it is really necessary

https://codereview.appspot.com/17910043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/views.py#newcode675
codereview/views.py:675: ### Decorators for request handlers ###
You forgot to remove this.

https://codereview.appspot.com/17910043/diff/1/codereview/views.py#newcode899
codereview/views.py:899: @deco.login_required
I'll call this "style deco". :)

[iannucci, 2013-10-30 03:47:35]

PTAL, includes rebase.

https://codereview.appspot.com/17910043/diff/1/codereview/decorators.py
File codereview/decorators.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/decorators.py#newco...
codereview/decorators.py:30: def require_method(*methods):
On 2013/10/28 15:41:55, M-A wrote:
> One thing that would be nice is to keep all them in alphabetic order. It makes
> searching for one item easier. wdyt?

SGTM, I just c+p'd them :)

Done.

https://codereview.appspot.com/17910043/diff/1/codereview/responses.py
File codereview/responses.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/responses.py#newcode57
codereview/responses.py:57: global COUNTER
On 2013/10/28 15:41:55, M-A wrote:
> This code is not threadsafe. I don't know if it is really necessary

Yeah, agreed, but let's do actual semantic changes later. If I start trying to
fix races, you're not going to be able to review anything :D

https://codereview.appspot.com/17910043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/17910043/diff/1/codereview/views.py#newcode675
codereview/views.py:675: ### Decorators for request handlers ###
On 2013/10/28 15:41:55, M-A wrote:
> You forgot to remove this.

Oops! done.

https://codereview.appspot.com/17910043/diff/1/codereview/views.py#newcode899
codereview/views.py:899: @deco.login_required
On 2013/10/28 15:41:55, M-A wrote:
> I'll call this "style deco". :)

:D

[M-A, 2013-10-30 12:59:16]

lgtm

[iannucci, 2013-10-30 23:19:21]

Committed as
https://code.google.com/p/rietveld/source/detail?r=f4b60f0c3bf56432eea3f3060b...
and
https://code.google.com/p/rietveld/source/detail?r=88778e0be667f72a3791e8d0c5...
(because I goofed and omitted the added files in the first commit :()

Merge committed as
https://code.google.com/p/rietveld/source/detail?r=fda2d2e0e21710feafcca07773...