Issue 179095: code review 179095: cgo: include line number information to keep go/printer...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 179095: code review 179095: cgo: include line number information to keep go/printer... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:

CC:
dho, golang-dev

Visibility:
Public.

Description

cgo: include line number information to keep go/printer happy Fixes issue 443.

Patch Set 1 #

Patch Set 2 : code review 179095: cgo: include line number information to keep go/printer... #

Patch Set 3 : code review 179095: cgo: include line number information to keep go/printer... #

Patch Set 4 : code review 179095: cgo: include line number information to keep go/printer... #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/cmd/cgo/main.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello dho (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 2 months ago (2009-12-17 22:20:54 UTC) #1

dho

On 2009/12/17 22:20:54, rsc wrote: > Hello dho (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

15 years, 2 months ago (2009-12-18 00:52:47 UTC) #2

rsc

15 years, 2 months ago (2009-12-18 01:04:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ca70213e75fa ***

cgo: include line number information to keep go/printer happy

Fixes issue 443.

R=dho
CC=golang-dev
http://codereview.appspot.com/179095

Expand All Messages | Collapse All Messages