Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(430)

Issue 178970043: ICU ticket #11336: UnicodeString: recombine stack buffer arrays (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by markus.icu
Modified:
1 year, 4 months ago
Reviewers:
andy.heninger
CC:
srl_icu-project.org, kcc1
Base URL:
http://source.icu-project.org/repos/icu/icu/trunk
Visibility:
Public.

Description

recombine stack buffer arrays; one int16_t for short length & flags

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -183 lines) Patch
M source/common/unicode/unistr.h View 11 chunks +101 lines, -53 lines 0 comments Download
M source/common/unistr.cpp View 29 chunks +80 lines, -104 lines 0 comments Download
M source/common/unistr_case.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M source/common/unistr_cnv.cpp View 6 chunks +11 lines, -21 lines 0 comments Download
M source/common/unistr_props.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
markus.icu
2 years, 10 months ago (2014-11-18 22:54:16 UTC) #1
andy.heninger
2 years, 10 months ago (2014-11-19 20:30:01 UTC) #2
https://codereview.appspot.com/178970043/diff/1/source/common/unistr_props.cpp
File source/common/unistr_props.cpp (right):

https://codereview.appspot.com/178970043/diff/1/source/common/unistr_props.cp...
source/common/unistr_props.cpp:4: *   Copyright (C) 1999-2014, International
Business Machines
No other changes in file, can revert this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted