Issue 1783044: SLING-1596, Reduce coupling between RequestData and SlingHttpServletRequestImpl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by bdelacretaz

Modified:
11 years, 2 months ago

Reviewers:

Base URL:
https://svn.apache.org/repos/asf/sling/trunk/

Visibility:
Public.

Uses request attribute instead of relying on SlingHttpServletRequestImpl to get the RequestData. See https://issues.apache.org/jira/browse/SLING-1596

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -27 lines)			Patch
		bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingHttpServletRequestImpl.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
		bundles/engine/src/main/java/org/apache/sling/engine/impl/request/RequestData.java	View		3 chunks	+18 lines, -27 lines	0 comments	Download