Issue 178050: Add cache to safe_eval

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 178050: Add cache to safe_eval (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by ced1

Modified:
16 years, 5 months ago

Reviewers:
bch, h.goebel, yangoon1

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remove Lock #

Total comments: 1

Patch Set 3 : Use digest instead of hexdigest #

Created: 16 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -14 lines)			Patch
	M	trytond/tools/misc.py	View	1 2	2 chunks	+30 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

h.goebel

16 years, 5 months ago (2009-12-15 16:24:32 UTC) #5

http://codereview.appspot.com/178050/diff/1003/5
File trytond/tools/misc.py (right):

http://codereview.appspot.com/178050/diff/1003/5#newcode523
trytond/tools/misc.py:523: if hashlib:
Since you are implementing a cache to gain speed, I suggest removing this
if-statement:

# change import section above like this:
try:
  import hashlib
  MD5 = hashlib.md5
except ImportError:
  import md5
  MD5 = md5.new

#change this if-statement into
key = MD5(source).digest()

Additionally, I see no need for an hexdigest here, so we can use a normals
digest, which cheaper.

Expand All Messages | Collapse All Messages