Issue 178043: code review 178043: generate replacement rune when asked to encode a negati...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 178043: code review 178043: generate replacement rune when asked to encode a negati... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by r

Modified:
15 years, 3 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

generate replacement rune when asked to encode a negative rune value. Fixes issue 425.

Patch Set 2 : code review 178043: generate replacement rune when asked to encode a negati... #

Total comments: 1

Patch Set 3 : code review 178043: generate replacement rune when asked to encode a negati... #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
	M	src/pkg/utf8/utf8.go	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/pkg/utf8/utf8_test.go	View	1	5 chunks	+21 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/178043/diff/7/1001 File src/pkg/utf8/utf8.go (right): http://codereview.appspot.com/178043/diff/7/1001#newcode232 src/pkg/utf8/utf8.go:232: return EncodeRune(RuneError, p) rune = RuneError is what ...

15 years, 3 months ago (2009-12-14 22:14:16 UTC) #2

15 years, 3 months ago (2009-12-14 22:19:57 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d33255fb9446 ***

generate replacement rune when asked to encode a negative rune value.
Fixes issue 425.

R=rsc
http://codereview.appspot.com/178043

Expand All Messages | Collapse All Messages