Issue 177590043: code review 177590043: net: FileListener on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 177590043: code review 177590043: net: FileListener on windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by mattn

Modified:
10 years, 3 months ago

Reviewers:

CC:
golang-codereviews, gobot, brainman

Visibility:
Public.

Description

net: FileListener on windows

Patch Set 1 #

Patch Set 2 : diff -r ffe33f1f1f17bf7d9bd14d8a8931dc905a75d011 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ffe33f1f1f17bf7d9bd14d8a8931dc905a75d011 http://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -11 lines)			Patch
M	src/net/fd_windows.go	View	1	1 chunk	+13 lines, -5 lines	0 comments	Download
M	src/net/file_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/net/file_windows.go	View	1	2 chunks	+107 lines, -4 lines	0 comments	Download
M	src/syscall/syscall_windows.go	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/syscall/zsyscall_windows.go	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/syscall/ztypes_windows.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mattn

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/

10 years, 4 months ago (2014-12-01 06:25:05 UTC) #1

gobot

R=alex.brainman@gmail.com (assigned by mattn.jp@gmail.com)

10 years, 4 months ago (2014-12-01 06:31:42 UTC) #2

gobot

10 years, 3 months ago (2014-12-19 05:16:24 UTC) #3

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/177590043 is best) in the description in your
new CL.

Thanks very much.

Expand All Messages | Collapse All Messages