[benchmark] Add config for HTTP method and cache control config

[benchmark] Add config for HTTP method and cache control config

R=tyoshino@chromium.org

Committed: https://code.google.com/p/pywebsocket/source/detail?r=861

[tyoshino (chromium.org), 2014-11-27 06:43:46]

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
src/example/xhr_benchmark.html:219: checked><label for="methodandcachePOST">POST
(No Cache)</label>
no cache? cache?

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
src/example/xhr_benchmark.html:229: ><label for="methodandcacheGETGACHE">GET
(Cache)</label>
GACHE -> CACHE

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/stand...
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:730: parsed = urlparse.urlsplit(self.path)
parsed -> parsed_path

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/xhr_b...
File src/mod_pywebsocket/xhr_benchmark_handler.py (right):

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:79: 
one vertical space between methods for the same class

[hiroshige, 2014-12-03 05:52:25]

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
src/example/xhr_benchmark.html:219: checked><label for="methodandcachePOST">POST
(No Cache)</label>
On 2014/11/27 06:43:45, tyoshino (chromium.org) wrote:
> no cache? cache?
no cache, because POST requests are never cached.
What kind of clarification is needed?

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
src/example/xhr_benchmark.html:229: ><label for="methodandcacheGETGACHE">GET
(Cache)</label>
On 2014/11/27 06:43:45, tyoshino (chromium.org) wrote:
> GACHE -> CACHE

Done.

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/stand...
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:730: parsed = urlparse.urlsplit(self.path)
On 2014/11/27 06:43:45, tyoshino (chromium.org) wrote:
> parsed -> parsed_path

Done.

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/xhr_b...
File src/mod_pywebsocket/xhr_benchmark_handler.py (right):

https://codereview.appspot.com/177470044/diff/20001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:79: 
On 2014/11/27 06:43:45, tyoshino (chromium.org) wrote:
> one vertical space between methods for the same class

Done.

[tyoshino (chromium.org), 2014-12-03 07:28:53]

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
File src/example/xhr_benchmark.html (right):

https://codereview.appspot.com/177470044/diff/20001/src/example/xhr_benchmark...
src/example/xhr_benchmark.html:219: checked><label for="methodandcachePOST">POST
(No Cache)</label>
On 2014/12/03 05:52:24, hiroshige wrote:
> On 2014/11/27 06:43:45, tyoshino (http://chromium.org) wrote:
> > no cache? cache?
> no cache, because POST requests are never cached.
> What kind of clarification is needed?

nvm

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark.js
File src/example/xhr_benchmark.js (right):

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark...
src/example/xhr_benchmark.js:243: xhr.open('GET', config.prefixUrl +
'_receive_nocache?' + size,
_getnocache

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark...
src/example/xhr_benchmark.js:248: xhr.open('GET', config.prefixUrl +
'_receive_cache?' + size,
_getcache

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:741: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_nocache'):
over 79 col

https://www.python.org/dev/peps/pep-0008

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:741: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_nocache'):
let's add "get"

_getnocache

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:747: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_cache'):
over 79 col

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:747: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_cache'):
_getcache

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
File src/mod_pywebsocket/xhr_benchmark_handler.py (right):

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:79: def do_receive_response(self,
bytes_to_send, chunked_mode, enable_cache):
do_receive_send_response

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:88: response_header +=
'Cache-control: private, max-age=10\r\n'
Control

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:90: response_header +=
'Cache-Control: no-cache, no-store, must-revalidate\r\n'
over 79 col

[hiroshige, 2015-02-17 11:28:13]

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark.js
File src/example/xhr_benchmark.js (right):

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark...
src/example/xhr_benchmark.js:243: xhr.open('GET', config.prefixUrl +
'_receive_nocache?' + size,
On 2014/12/03 07:28:52, tyoshino (chromium.org) wrote:
> _getnocache

Done.

https://codereview.appspot.com/177470044/diff/60001/src/example/xhr_benchmark...
src/example/xhr_benchmark.js:248: xhr.open('GET', config.prefixUrl +
'_receive_cache?' + size,
On 2014/12/03 07:28:52, tyoshino (chromium.org) wrote:
> _getcache

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
File src/mod_pywebsocket/standalone.py (right):

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:741: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_nocache'):
On 2014/12/03 07:28:53, tyoshino (chromium.org) wrote:
> let's add "get"
> 
> _getnocache

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:741: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_nocache'):
On 2014/12/03 07:28:53, tyoshino (chromium.org) wrote:
> over 79 col
> 
> https://www.python.org/dev/peps/pep-0008

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:747: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_cache'):
On 2014/12/03 07:28:52, tyoshino (chromium.org) wrote:
> _getcache

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/stand...
src/mod_pywebsocket/standalone.py:747: if parsed_path.path ==
(xhr_benchmark_helper_prefix + '_receive_cache'):
On 2014/12/03 07:28:52, tyoshino (chromium.org) wrote:
> over 79 col

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
File src/mod_pywebsocket/xhr_benchmark_handler.py (right):

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:79: def do_receive_response(self,
bytes_to_send, chunked_mode, enable_cache):
On 2014/12/03 07:28:53, tyoshino (chromium.org) wrote:
> do_receive_send_response
How about do_receive_and_parse() and do_receive() in Patch Set 4?
do_receive_send_response is a little confusing (receive? send?).

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:88: response_header +=
'Cache-control: private, max-age=10\r\n'
On 2014/12/03 07:28:53, tyoshino (chromium.org) wrote:
> Control

Done.

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:90: response_header +=
'Cache-Control: no-cache, no-store, must-revalidate\r\n'
On 2014/12/03 07:28:53, tyoshino (chromium.org) wrote:
> over 79 col

Done.

[tyoshino (chromium.org), 2015-04-24 07:25:08]

lgtm

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
File src/mod_pywebsocket/xhr_benchmark_handler.py (right):

https://codereview.appspot.com/177470044/diff/60001/src/mod_pywebsocket/xhr_b...
src/mod_pywebsocket/xhr_benchmark_handler.py:79: def do_receive_response(self,
bytes_to_send, chunked_mode, enable_cache):
On 2015/02/17 11:28:13, hiroshige wrote:
> On 2014/12/03 07:28:53, tyoshino (http://chromium.org) wrote:
> > do_receive_send_response
> How about do_receive_and_parse() and do_receive() in Patch Set 4?
> do_receive_send_response is a little confusing (receive? send?).

OK. Thanks.

[hiroshige, 2015-07-29 07:57:05]

Committed patchset #5 (id:160001) manually as r861 (presubmit successful).