Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2197)

Issue 176260043: Carry current context content type into fake context when switching

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by TiagoMatos
Modified:
9 years, 5 months ago
Reviewers:
shawn.p.huang, fujiwara, Peng
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Carry current context content type into fake context when switching When focus moves out of a context to the fake context we should keep the content type properties as they were in the focused out context. This allows panel implementations to show the proper UI while input focus moves away temporarily from a text entry. E.g. a password entry is focused and the user clicks on the panel UI. At this point ibus switches the currently focused context to the fake context and emits set-content-type with the fake context properties which are empty and thus the panel reacts to it. This isn't the intended behavior though since, from a user POV, the password entry is still the context that will be getting text input when the panel UI gets dismissed. R=shawn.p.huang@gmail.com BUG=https://bugzilla.gnome.org/show_bug.cgi?id=730628

Patch Set 1 #

Total comments: 1

Patch Set 2 : v2: fixed line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -35 lines) Patch
M bus/ibusimpl.c View 1 2 chunks +6 lines, -0 lines 0 comments Download
M bus/inputcontext.h View 1 chunk +10 lines, -0 lines 0 comments Download
M bus/inputcontext.c View 3 chunks +56 lines, -35 lines 0 comments Download

Messages

Total messages: 3
fujiwara
9 years, 5 months ago (2014-11-26 08:15:28 UTC) #1
fujiwara
LGTM. I just wonder if bus_input_context_set_content_type() is better than bus_panel_proxy_set_content_type() in bus_panel_proxy_focus_in/_out() because bus_panel_proxy_set_content_type() might ...
9 years, 5 months ago (2014-11-26 08:25:01 UTC) #2
Peng
9 years, 5 months ago (2014-11-26 19:21:49 UTC) #3
lgtm

https://codereview.appspot.com/176260043/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

https://codereview.appspot.com/176260043/diff/1/bus/ibusimpl.c#newcode639
bus/ibusimpl.c:639: bus_input_context_get_content_type (ibus->focused_context,
&purpose, &hints);
more than 80 chars
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b