Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1719)

Issue 176220043: Issue 471: Support WP8.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by peleyal
Modified:
4 years, 10 months ago
Reviewers:
class, jmcgrew
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 471: Support WP8.1 The new Google Apis WP 8.1 projects are based on code which was submitted to our samples repository a week ago - https://code.google.com/p/google-api-dotnet-client/source/detail?r=3333cd2566452c60cc946ff0eb125c243c978fa1&repo=samples * It includes renaming UderId to UserId (awkward!) and Stroage to Storage :) * Notice the new comment to AuthorizationCodeBroker which explains what the user should do (store the auth result in the data storage). Next step after committing this one, is to publish the new package to WP 8.1 and improve the documentation.

Patch Set 1 #

Patch Set 2 : AuthorizationCodeBroker main class comment #

Total comments: 26

Patch Set 3 : comments - gus and gesse #

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1094 lines, -146 lines) Patch
M GoogleApisClient.sln View 3 chunks +52 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/GoogleApis.Auth.DotNet4.csproj View 1 2 3 1 chunk +10 lines, -11 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs View 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.DotNet4/app.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.DotNet4/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.Mvc4/GoogleApis.Auth.Mvc4.csproj View 1 2 3 1 chunk +10 lines, -11 lines 0 comments Download
M Src/GoogleApis.Auth.Mvc4/app.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.Mvc4/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.Tests/GoogleApis.Auth.Tests.csproj View 1 2 3 2 chunks +10 lines, -11 lines 0 comments Download
M Src/GoogleApis.Auth.Tests/app.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.Tests/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.WP/GoogleApis.Auth.WP.csproj View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M Src/GoogleApis.Auth.WP/OAuth2/GoogleWebAuthorizationBroker.cs View 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.WP/packages.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Src/GoogleApis.Auth.WP81/GoogleApis.Auth.WP81.csproj View 1 2 1 chunk +153 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs View 1 2 3 1 chunk +109 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeWPInstalledApp.cs View 1 chunk +75 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/OAuth2/SerializableWebAuthResult.cs View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/Properties/AssemblyInfo.cs View 1 chunk +41 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/app.config View 1 chunk +19 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WP81/packages.config View 1 chunk +7 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/GoogleApis.Auth.Windows.csproj View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/OAuth2/GoogleWebAuthorizationBroker.cs View 4 chunks +4 lines, -4 lines 0 comments Download
A Src/GoogleApis.Auth.Windows/app.config View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/packages.config View 1 chunk +1 line, -2 lines 0 comments Download
M Src/GoogleApis.Auth/GoogleApis.Auth.csproj View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/UserCredential.cs View 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Core/GoogleApis.Core.csproj View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M Src/GoogleApis.Core/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M Src/GoogleApis.DotNet4/app.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.DotNet4/packages.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Tests/GoogleApis.Tests.csproj View 1 2 3 2 chunks +8 lines, -12 lines 0 comments Download
M Src/GoogleApis.Tests/app.config View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Tests/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.WP/GoogleApis.WP.csproj View 1 2 3 1 chunk +9 lines, -9 lines 0 comments Download
M Src/GoogleApis.WP/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A Src/GoogleApis.WP81/Apis/Util/Store/PasswordVaultDataStore.cs View 1 chunk +101 lines, -0 lines 0 comments Download
A Src/GoogleApis.WP81/GoogleApis.WP81.csproj View 1 2 3 1 chunk +142 lines, -0 lines 0 comments Download
A Src/GoogleApis.WP81/Properties/AssemblyInfo.cs View 1 chunk +41 lines, -0 lines 0 comments Download
A Src/GoogleApis.WP81/app.config View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A Src/GoogleApis.WP81/packages.config View 1 chunk +8 lines, -0 lines 0 comments Download
M Src/GoogleApis.Windows/Apis/Util/Store/StorageDataStore.cs View 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Windows/GoogleApis.Windows.csproj View 1 2 3 1 chunk +7 lines, -14 lines 0 comments Download
A Src/GoogleApis.Windows/app.config View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Src/GoogleApis.Windows/packages.config View 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis/GoogleApis.csproj View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M Src/GoogleApis/packages.config View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Google.Apis.Release/Program.cs View 2 chunks +10 lines, -1 line 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.Auth.VERSION.nuspec View 1 chunk +7 lines, -0 lines 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.Core.VERSION.nuspec View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.VERSION.nuspec View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9
peleyal
4 years, 11 months ago (2014-11-23 20:37:17 UTC) #1
class
On 2014/11/23 20:37:17, peleyal wrote: LGTM.
4 years, 10 months ago (2014-11-25 17:33:56 UTC) #2
peleyal
Comments to myself :) https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right): https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs#newcode42 Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:42: /// the auth result, and ...
4 years, 10 months ago (2014-11-25 20:15:55 UTC) #3
jmcgrew
https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right): https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs#newcode34 Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:34: /// This broker most important method is <see cref="ReceiveCodeAsync"/>. ...
4 years, 10 months ago (2014-11-25 20:46:59 UTC) #4
class
A few nits https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windows/app.config File Src/GoogleApis.Auth.Windows/app.config (right): https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windows/app.config#newcode4 Src/GoogleApis.Auth.Windows/app.config:4: <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1"> 8 spaces / tab ...
4 years, 10 months ago (2014-11-25 20:49:26 UTC) #5
peleyal
Thanks for your feedback guys :) https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right): https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs#newcode34 Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:34: /// This broker ...
4 years, 10 months ago (2014-11-26 02:54:01 UTC) #6
peleyal
Friendly ping :)
4 years, 10 months ago (2014-12-02 04:26:47 UTC) #7
jmcgrew
On 2014/12/02 04:26:47, peleyal wrote: > Friendly ping :) LGTM
4 years, 10 months ago (2014-12-02 07:04:43 UTC) #8
class
4 years, 10 months ago (2014-12-02 17:46:28 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b