Issue 471: Support WP8.1

Issue 471: Support WP8.1

The new Google Apis WP 8.1 projects are based on code which was submitted to our samples repository a week ago - https://code.google.com/p/google-api-dotnet-client/source/detail?r=3333cd2566452c60cc946ff0eb125c243c978fa1&repo=samples

* It includes renaming UderId to UserId (awkward!) and Stroage to Storage :)
* Notice the new comment to AuthorizationCodeBroker which explains what the user should do (store the auth result in the data storage).

Next step after committing this one, is to publish the new package to WP 8.1 and improve the documentation.

[class, 2014-11-25 17:33:56]

On 2014/11/23 20:37:17, peleyal wrote:

LGTM.

[peleyal, 2014-11-25 20:15:55]

Comments to myself :)

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:42: /// the auth
result, and if a code was received the framework will convert it in turn to
access and refresh token.
access and refresh tokens

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:106: #endregion
The #endregion should be before InvokeFrom UIThread

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs:76: ///
<summary>
change the order, public methods should appear first

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
File Src/GoogleApis.Auth.Windows/app.config (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
Src/GoogleApis.Auth.Windows/app.config:3: <runtime>
Change to uses spaces and not tabs

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP/app.config
File Src/GoogleApis.WP/app.config (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP/app.con...
Src/GoogleApis.WP/app.config:19: </configuration>
revert

[jmcgrew, 2014-11-25 20:46:59]

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:34: /// This broker
most important method is <see cref="ReceiveCodeAsync"/>.
broker -> broker's

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:39: /// When the app
is being activated again, the developer MUST stores the auth result (which may
contain the access
stores -> store

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/WebAuthResult.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/WebAuthResult.cs:25: public class WebAuthResult
Maybe use a more unique name, like SerializableWebAuth[entication]Result, so
it's obvious when to use this instead of the original class.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP81/Apis/...
File Src/GoogleApis.WP81/Apis/Util/Store/PasswordVaultDataStore.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP81/Apis/...
Src/GoogleApis.WP81/Apis/Util/Store/PasswordVaultDataStore.cs:42: return
TaskEx.Delay(0);
If available in this framework version, Task.CompletedTask or Task.FromResult(0)
would be more idiomatic.

[class, 2014-11-25 20:49:26]

A few nits

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
File Src/GoogleApis.Auth.Windows/app.config (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
Src/GoogleApis.Auth.Windows/app.config:4: <assemblyBinding
xmlns="urn:schemas-microsoft-com:asm.v1">
8 spaces / tab seems rather large... recommend using two spaces / tab as done
elsewhere in your XML

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.DotNet4/Go...
File Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.DotNet4/Go...
Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj:63:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Extensions.dll</HintPath>
2.2.28?

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (left):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:105:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Primitives.dll</HintPath>
2.2.28?

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:100:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Extensions.dll</HintPath>
should this be 2.2.28?

[peleyal, 2014-11-26 02:54:01]

Thanks for your feedback guys :)

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:34: /// This broker
most important method is <see cref="ReceiveCodeAsync"/>.
On 2014/11/25 20:46:59, jmcgrew wrote:
> broker -> broker's

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:39: /// When the app
is being activated again, the developer MUST stores the auth result (which may
contain the access
On 2014/11/25 20:46:59, jmcgrew wrote:
> stores -> store

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:42: /// the auth
result, and if a code was received the framework will convert it in turn to
access and refresh token.
On 2014/11/25 20:15:55, peleyal wrote:
> access and refresh tokens

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/AuthorizationCodeBroker.cs:106: #endregion
On 2014/11/25 20:15:54, peleyal wrote:
> The #endregion should be before InvokeFrom UIThread

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs:76: ///
<summary>
On 2014/11/25 20:15:55, peleyal wrote:
> change the order, public methods should appear first

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
File Src/GoogleApis.Auth.WP81/OAuth2/WebAuthResult.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.WP81/...
Src/GoogleApis.Auth.WP81/OAuth2/WebAuthResult.cs:25: public class WebAuthResult
On 2014/11/25 20:46:59, jmcgrew wrote:
> Maybe use a more unique name, like SerializableWebAuth[entication]Result, so
> it's obvious when to use this instead of the original class.

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
File Src/GoogleApis.Auth.Windows/app.config (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
Src/GoogleApis.Auth.Windows/app.config:3: <runtime>
On 2014/11/25 20:15:55, peleyal wrote:
> Change to uses spaces and not tabs

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Auth.Windo...
Src/GoogleApis.Auth.Windows/app.config:4: <assemblyBinding
xmlns="urn:schemas-microsoft-com:asm.v1">
On 2014/11/25 20:49:26, class wrote:
> 8 spaces / tab seems rather large... recommend using two spaces / tab as done
> elsewhere in your XML

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.DotNet4/Go...
File Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.DotNet4/Go...
Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj:63:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Extensions.dll</HintPath>
On 2014/11/25 20:49:26, class wrote:
> 2.2.28?

Thanks!

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (left):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:105:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Primitives.dll</HintPath>
On 2014/11/25 20:49:26, class wrote:
> 2.2.28?

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
File Src/GoogleApis.Tests/GoogleApis.Tests.csproj (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.Tests/Goog...
Src/GoogleApis.Tests/GoogleApis.Tests.csproj:100:
<HintPath>..\..\packages\Microsoft.Net.Http.2.2.22\lib\net40\System.Net.Http.Extensions.dll</HintPath>
On 2014/11/25 20:49:26, class wrote:
> should this be 2.2.28?

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP/app.config
File Src/GoogleApis.WP/app.config (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP/app.con...
Src/GoogleApis.WP/app.config:19: </configuration>
On 2014/11/25 20:15:55, peleyal wrote:
> revert

Done.

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP81/Apis/...
File Src/GoogleApis.WP81/Apis/Util/Store/PasswordVaultDataStore.cs (right):

https://codereview.appspot.com/176220043/diff/20001/Src/GoogleApis.WP81/Apis/...
Src/GoogleApis.WP81/Apis/Util/Store/PasswordVaultDataStore.cs:42: return
TaskEx.Delay(0);
On 2014/11/25 20:46:59, jmcgrew wrote:
> If available in this framework version, Task.CompletedTask or
Task.FromResult(0)
> would be more idiomatic.

Task.CompletedTask isn't exposed.
It looks OK to me to use Delay(0), cause it actually DOES return completed task.
http://stackoverflow.com/questions/18527149/task-yield-versus-task-delay0

[peleyal, 2014-12-02 04:26:47]

Friendly ping :)

[jmcgrew, 2014-12-02 07:04:43]

On 2014/12/02 04:26:47, peleyal wrote:
> Friendly ping :)

LGTM

[class, 2014-12-02 17:46:28]

LGTM