Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(538)

Issue 176140043: i#1551 Port DynamoRIO to ARM: rename segment_register to thread_register (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by zhaoqin
Modified:
9 years, 5 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Base URL:
https://dynamorio.googlecode.com/svn/trunk
Visibility:
Public.

Description

i#1551 Port DynamoRIO to ARM: rename segment_register to thread_register - rename is_segment_register_initialized to is_thread_register_initialized - rename read_selector to read_thread_register - implement read_thread_register on ARM R=bruening@google.com BUG=1551 Committed: https://code.google.com/p/dynamorio/source/detail?r=3018

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M core/unix/os.c View 14 chunks +18 lines, -18 lines 0 comments Download
M core/unix/tls.h View 2 chunks +19 lines, -8 lines 2 comments Download
M core/unix/tls_linux_x86.c View 4 chunks +4 lines, -4 lines 0 comments Download
M core/unix/tls_macos.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
zhaoqin
Please take a look
9 years, 5 months ago (2014-11-21 20:36:00 UTC) #1
bruening
LGTM w/ request https://codereview.appspot.com/176140043/diff/20001/core/unix/tls.h File core/unix/tls.h (right): https://codereview.appspot.com/176140043/diff/20001/core/unix/tls.h#newcode138 core/unix/tls.h:138: asm volatile("mrc p15, 0, %0, c13, ...
9 years, 5 months ago (2014-11-22 15:34:47 UTC) #2
zhaoqin
9 years, 5 months ago (2014-11-24 16:30:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 3018 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b