Issue 1761042: code review 1761042: big: added a few missing functions:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1761042: code review 1761042: big: added a few missing functions: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by gri

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

big: added a few missing functions: - sign to determine if a value is < 0, == 0, > 0 - abs to compute absolute value - Rat.IsInt to test if a rational number is representable as an integer

Patch Set 1 #

Patch Set 2 : code review 1761042: big: added a few missing functions: #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -0 lines)			Patch
M	src/pkg/big/int.go	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/pkg/big/int_test.go	View	2 chunks	+29 lines, -0 lines	0 comments	Download
M	src/pkg/big/rat.go	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/pkg/big/rat_test.go	View	2 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-12 22:50:47 UTC) #1

gri

14 years, 8 months ago (2010-07-12 23:09:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=adf4892ff924 ***

big: added a few missing functions:
- sign to determine if a value is < 0, == 0, > 0
- abs to compute absolute value
- Rat.IsInt to test if a rational number is representable as an integer

R=rsc
CC=golang-dev
http://codereview.appspot.com/1761042

Expand All Messages | Collapse All Messages