Fix loading python26.bc from drives other than C: (Issue 96)

Split sys_path on the correct platform-specific delimiter.  See http://code.google.com/p/unladen-swallow/issues/detail?id=96

[Jeffrey Yasskin, 2009-12-14 05:38:49]

Oops. LGTM.

http://codereview.appspot.com/176073/diff/1/2
File Python/global_llvm_data.cc (right):

http://codereview.appspot.com/176073/diff/1/2#newcode5
Python/global_llvm_data.cc:5: #undef MAXPATHLEN
Why #undef MAXPATHLEN? Does it break llvm somewhere?

http://codereview.appspot.com/176073/diff/1/2#newcode87
Python/global_llvm_data.cc:87: StringRef(Py_GetPath()).split(sys_path, delim);
StringRef::split() has an overload taking a char, so you should be able to pass
just DELIM. I'm not sure why I didn't use a char in the first place.

[James Abbatiello, 2009-12-14 06:03:00]

Committing

http://codereview.appspot.com/176073/diff/1/2
File Python/global_llvm_data.cc (right):

http://codereview.appspot.com/176073/diff/1/2#newcode5
Python/global_llvm_data.cc:5: #undef MAXPATHLEN
On 2009/12/14 05:38:49, Jeffrey Yasskin wrote:
> Why #undef MAXPATHLEN? Does it break llvm somewhere?

You get duplicate defintion warnings since config.h also defines MAXPATHLEN but
with a different value.

http://codereview.appspot.com/176073/diff/1/2#newcode87
Python/global_llvm_data.cc:87: StringRef(Py_GetPath()).split(sys_path, delim);
On 2009/12/14 05:38:49, Jeffrey Yasskin wrote:
> StringRef::split() has an overload taking a char, so you should be able to
pass
> just DELIM. I'm not sure why I didn't use a char in the first place.

The version taking a char has different semantics (only splits the string into
at most two pieces).

[Jeffrey Yasskin (google), 2009-12-14 06:08:08]

On Sun, Dec 13, 2009 at 10:03 PM,  <abbeyj@gmail.com> wrote:
> Committing
>
>
>
> http://codereview.appspot.com/176073/diff/1/2
> File Python/global_llvm_data.cc (right):
>
> http://codereview.appspot.com/176073/diff/1/2#newcode5
> Python/global_llvm_data.cc:5: #undef MAXPATHLEN
> On 2009/12/14 05:38:49, Jeffrey Yasskin wrote:
>>
>> Why #undef MAXPATHLEN? Does it break llvm somewhere?
>
> You get duplicate defintion warnings since config.h also defines
> MAXPATHLEN but with a different value.

Ah

> http://codereview.appspot.com/176073/diff/1/2#newcode87
> Python/global_llvm_data.cc:87: StringRef(Py_GetPath()).split(sys_path,
> delim);
> On 2009/12/14 05:38:49, Jeffrey Yasskin wrote:
>>
>> StringRef::split() has an overload taking a char, so you should be
>
> able to pass
>>
>> just DELIM. I'm not sure why I didn't use a char in the first place.
>
> The version taking a char has different semantics (only splits the
> string into at most two pieces).

Oops, you're right.