code review 176062: Adds the SHA256 Hash functions as specified in FIPS 180-2.

Adds the SHA256 Hash functions as specified in FIPS 180-2.

[andy davis, 2009-12-13 03:09:34]

Hello golang-dev@googlegroups.com,

I'd like you to review the following change.

[andy davis, 2009-12-13 03:58:01]

Hello golang-dev@googlegroups.com,

I'd like you to review the following change.

[rsc, 2009-12-13 05:17:08]

Thanks for writing this.  Two small things.

1. If you have a SHA-256 implementation somewhere else,
could you run the strings from sha1_test.go (same as in
md5_test.go) through it to generate a bigger test table?
I know things are correct now, but especially if we end up
with assembly versions of the block routine, the small tests
at the beginning of the usual list are good for building confidence.

2. Could you please complete a CLA as described at
http://golang.org/doc/contribute.html#copyright?

Thanks.
Russ

[andy davis, 2009-12-13 05:49:51]

Thanks, I updated the tests and completed the CLA.

On 2009/12/13 05:17:08, rsc wrote:
> Thanks for writing this.  Two small things.
> 
> 1. If you have a SHA-256 implementation somewhere else,
> could you run the strings from sha1_test.go (same as in
> md5_test.go) through it to generate a bigger test table?
> I know things are correct now, but especially if we end up
> with assembly versions of the block routine, the small tests
> at the beginning of the usual list are good for building confidence.
> 
> 2. Could you please complete a CLA as described at
> http://golang.org/doc/contribute.html#copyright?
> 
> Thanks.
> Russ
>

[andy davis, 2009-12-14 23:05:00]

Added the test strings from SHA1 and cleaned up comments.

[rsc, 2009-12-14 23:07:27]

LGTM

Thanks.

[rsc, 2009-12-14 23:09:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=02c4988339a3 ***

crypto/sha256: new package

R=rsc
CC=golang-dev
http://codereview.appspot.com/176062

Committer: Russ Cox <rsc@golang.org>