Issue 176058: code review 176058: Fix to allow error returns on syscalls with 64-bit return

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 176058: code review 176058: Fix to allow error returns on syscalls with 64-bit return (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by cw

Modified:
14 years, 4 months ago

Reviewers:

CC:
dho, rsc, r

Visibility:
Public.

Description

Fix to allow error returns on syscalls with 64-bit return values on 32-bt platforms.

Patch Set 1 #

Patch Set 2 : code review 176058: Fix to allow error returns on syscalls with 64-bit return #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -29 lines)			Patch
M	src/pkg/syscall/mksyscall.sh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View	5 chunks	+27 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello dho, r, rsc (cc: cw), I'd like you to review the following change.

14 years, 4 months ago (2009-12-12 06:48:01 UTC) #1

rsc

14 years, 4 months ago (2009-12-13 21:05:53 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=8f27dd511198 ***

syscall: fix error return bug for 64-bit return on 32-bit platform

R=dho, rsc
CC=r
http://codereview.appspot.com/176058

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages