Issue 1760043: code review 1760043: go spec: specify len/cap for nil slices, maps, and channels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1760043: code review 1760043: go spec: specify len/cap for nil slices, maps, and channels (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by gri

Modified:
14 years, 8 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

go spec: specify len/cap for nil slices, maps, and channels Fixes issue 891.

Patch Set 2 : code review 1760043: go spec: specify len/cap for nil slices, maps, and channels #

Patch Set 3 : code review 1760043: go spec: specify len/cap for nil slices, maps, and channels #

Total comments: 2

Patch Set 4 : code review 1760043: go spec: specify len/cap for nil slices, maps, and channels #

Patch Set 5 : code review 1760043: go spec: specify len/cap for nil slices, maps, and channels #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -21 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4	7 chunks	+23 lines, -21 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-13 01:29:06 UTC) #1

LGTM http://codereview.appspot.com/1760043/diff/4001/5001 File doc/go_spec.html (right): http://codereview.appspot.com/1760043/diff/4001/5001#newcode1157 doc/go_spec.html:1157: For a map <code>m</code> it can be discovered ...

14 years, 8 months ago (2010-07-13 17:29:16 UTC) #2

gri

14 years, 8 months ago (2010-07-13 18:55:07 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e18d4fc8c44f ***

go spec: specify len/cap for nil slices, maps, and channels

Fixes issue 891.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1760043

Expand All Messages | Collapse All Messages