Issue 17580043: database/sql: Add optional ColumnsCounter interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 17580043: database/sql: Add optional ColumnsCounter interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by julienschmidt

Modified:
10 years, 11 months ago

Reviewers:
ahormann, golang-dev

Visibility:
Public.

Description

database/sql: Add optional ColumnsCounter interface Creating a slice of all column names is expensive, since it requires allocations and, depending on the driver, maybe even additional network activity. Therefore rows.Columns should not be used just to get the length of the slice. ColumnsCounter adds an optional cheaper way, since getting the number of columns is often much cheaper.

Patch Set 1 #

Patch Set 2 : diff -r f9af8b83c78c https://code.google.com/p/go #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	src/pkg/database/sql/driver/driver.go	View	1	1 chunk	+9 lines, -0 lines	1 comment	Download
	M	src/pkg/database/sql/sql.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ahormann

LGTM https://codereview.appspot.com/17580043/diff/20001/src/pkg/database/sql/driver/driver.go File src/pkg/database/sql/driver/driver.go (right): https://codereview.appspot.com/17580043/diff/20001/src/pkg/database/sql/driver/driver.go#newcode181 src/pkg/database/sql/driver/driver.go:181: type ColumnsCounter interface { I'd name it NumColumns ...

10 years, 11 months ago (2013-12-17 15:01:20 UTC) #2

julienschmidt

On 2013/12/17 15:01:20, ahormann wrote: > LGTM > > https://codereview.appspot.com/17580043/diff/20001/src/pkg/database/sql/driver/driver.go > File src/pkg/database/sql/driver/driver.go (right): > ...

10 years, 11 months ago (2013-12-17 16:44:53 UTC) #3

ahormann

10 years, 11 months ago (2013-12-17 16:48:04 UTC) #4

On 2013/12/17 16:44:53, julienschmidt wrote:
> On 2013/12/17 15:01:20, ahormann wrote:
> > LGTM
> > 
> >
>
https://codereview.appspot.com/17580043/diff/20001/src/pkg/database/sql/drive...
> > File src/pkg/database/sql/driver/driver.go (right):
> > 
> >
>
https://codereview.appspot.com/17580043/diff/20001/src/pkg/database/sql/drive...
> > src/pkg/database/sql/driver/driver.go:181: type ColumnsCounter interface {
> > I'd name it NumColumns or ColumnCount for consistency with Columns.
> > It's more of an attribute access than an action to me.
> 
> NumColumns might be the best name since it is consistent with (*Stmt).NumInput
> But how to name the Interface then? NumColumnser? Sounds weird to me.

IMO it can still be ColumnCounter, but please drop the infix "s", it reads weird
- or better, wait for a native speaker to argue that point, I might be wrong.

Expand All Messages | Collapse All Messages