Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2976)

Issue 175430044: i#1551 Port DynamoRIO to ARM: fix link error for ARM build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by zhaoqin
Modified:
4 years, 9 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Base URL:
https://dynamorio.googlecode.com/svn/trunk
Visibility:
Public.

Description

i#1551 Port DynamoRIO to ARM: fix link error for ARM build R=bruening@google.com BUG=1551 Committed: https://code.google.com/p/dynamorio/source/detail?r=3011

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -10 lines) Patch
M core/arch/arm/arm.asm View 1 2 4 chunks +52 lines, -0 lines 0 comments Download
M core/arch/arm/clean_call_opt.c View 2 chunks +29 lines, -0 lines 0 comments Download
M core/arch/arm/emit_utils.c View 2 chunks +15 lines, -0 lines 0 comments Download
M core/arch/arm/instr.c View 2 chunks +9 lines, -1 line 0 comments Download
M core/arch/arm/mangle.c View 3 chunks +45 lines, -0 lines 0 comments Download
M core/arch/emit_utils_shared.c View 2 chunks +2 lines, -2 lines 0 comments Download
M core/arch/mangle_shared.c View 1 chunk +3 lines, -0 lines 0 comments Download
M core/arch/x86/clean_call_opt.c View 1 chunk +0 lines, -2 lines 0 comments Download
M core/arch/x86/mangle.c View 1 chunk +0 lines, -2 lines 0 comments Download
M core/arch/x86_code.c View 1 chunk +4 lines, -0 lines 0 comments Download
M core/emit.c View 1 chunk +2 lines, -1 line 0 comments Download
M core/fragment.c View 1 chunk +7 lines, -2 lines 0 comments Download
M core/unix/signal_linux_arm.c View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
zhaoqin
4 years, 9 months ago (2014-11-20 17:03:16 UTC) #1
bruening
LGTM https://codereview.appspot.com/175430044/diff/1/core/arch/arm/arm.asm File core/arch/arm/arm.asm (right): https://codereview.appspot.com/175430044/diff/1/core/arch/arm/arm.asm#newcode222 core/arch/arm/arm.asm:222: bl GLOBAL_REF(unexpected_return) I think all of these also ...
4 years, 9 months ago (2014-11-20 23:54:09 UTC) #2
zhaoqin
4 years, 9 months ago (2014-11-21 16:53:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 3011 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b