Issue 1752044: code review 1752044: 5l, 6l, 8l: reject invalid input files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1752044: code review 1752044: 5l, 6l, 8l: reject invalid input files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

5l, 6l, 8l: reject invalid input files Fixes issue 925. Fixes issue 926. Fixes issue 927. Fixes issue 928. Fixes issue 929. Fixes issue 930.

Patch Set 1 #

Patch Set 2 : code review 1752044: 5l, 6l, 8l: reject invalid input files #

Patch Set 3 : code review 1752044: 5l, 6l, 8l: reject invalid input files #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -15 lines)			Patch
M	src/cmd/5l/obj.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/6l/l.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/obj.c	View	1	4 chunks	+16 lines, -6 lines	0 comments	Download
M	src/cmd/8l/l.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/obj.c	View	1	4 chunks	+16 lines, -6 lines	0 comments	Download
M	src/cmd/ld/lib.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-16 22:59:44 UTC) #1

LGTM histfrog! might be worth making a "mangled input file" function if there are any ...

14 years, 8 months ago (2010-07-16 23:03:34 UTC) #2

rsc

14 years, 8 months ago (2010-07-16 23:16:19 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=38ac4f394e2f ***

5l, 6l, 8l: reject invalid input files

Fixes issue 925.
Fixes issue 926.
Fixes issue 927.
Fixes issue 928.
Fixes issue 929.
Fixes issue 930.

R=r
CC=golang-dev
http://codereview.appspot.com/1752044

Expand All Messages | Collapse All Messages