code review 175140043: x/net/webdav: part 1 of a memLS implementation.

x/net/webdav: part 1 of a memLS implementation.

[nigeltao, 2014-11-17 06:21:07]

Hello dave@cheney.net, nmvc@google.com (cc: bradfitz@golang.org,
dr.volker.dobler@gmail.com, golang-codereviews@googlegroups.com,
robert.stepanek@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[rostdotio, 2014-11-17 14:55:39]

https://codereview.appspot.com/175140043/diff/60001/webdav/lock.go
File webdav/lock.go (right):

https://codereview.appspot.com/175140043/diff/60001/webdav/lock.go#newcode107
webdav/lock.go:107: // OwnerXML is the verbatim <owner> XML given in a LOCK HTTP
request.
the verbatim XML in OwnerXML does not preserve XML namespaces with the current
implementation of lockinfo: http://play.golang.org/p/BlPeMyBig7
this requires clients to hardcode the xmlns prefix for the "DAV:" namespace to
"D" for sane XML output in writeLockInfo. in addition, it can cause issues if
implementors of LockSystem unmarshal OwnerXML for custom processing.

RFC 4918 requires the content of owner value to preserve the same XML
information like dead WebDAV properties ([1]).

Possible fix: implement the xml.Unmarshaler interface for owner struct to
collect the xml.Tokens and unmarshal them into a string. (FYI, I did something
similar for dead properties
https://github.com/rostdotio/webdav/blob/master/caldav/caldav.go#L507)

[1] http://tools.ietf.org/html/rfc4918#section-4.3

[gobot, 2014-12-19 05:16:17]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/175140043 is best) in the description in your
new CL.

Thanks very much.

[nigeltao, 2015-01-07 05:55:04]

This code review has moved to https://go-review.googlesource.com/2430