Issue 174680044: Remove draft08 option from PerMessageDeflateExtensionProcessor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 174680044: Remove draft08 option from PerMessageDeflateExtensionProcessor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by tyoshino (chromium.org)

Modified:
8 years, 8 months ago

Reviewers:
hiroshige

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove draft8 option from PerMessageDeflateExtensionProcessor Release note: Remove draft8 option from PerMessageDeflateExtensionProcessor BUG=https://code.google.com/p/pywebsocket/issues/detail?id=133 R=hiroshige@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=863

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -24 lines)			Patch
	M	src/mod_pywebsocket/extensions.py	View	1 2 3	5 chunks	+10 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hiroshige

On 2014/11/27 06:53:54, tyoshino (chromium.org) wrote: lgtm.

9 years, 2 months ago (2015-02-17 11:07:32 UTC) #2

hiroshige

On 2015/02/17 11:07:32, hiroshige wrote: > On 2014/11/27 06:53:54, tyoshino (http://chromium.org) wrote: > > lgtm. ...

8 years, 8 months ago (2015-08-18 04:27:36 UTC) #3

tyoshino (chromium.org)

8 years, 8 months ago (2015-08-19 10:55:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r863 (presubmit successful).

Expand All Messages | Collapse All Messages