Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 1746042: [PATCH] Delete assert in ComputeKeyFunction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Jeffrey Yasskin
Modified:
9 years, 4 months ago
Reviewers:
DougGregor, cfe-commits
Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.

Description

The function runs fine without it, since there's an explicit guard on isPolymorphic, and virtual bases don't affect the key function calculation. This allows people to call ASTContext::getKeyFunction on arbitrary classes.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M include/clang/AST/ASTContext.h View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/AST/RecordLayoutBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Jeffrey Yasskin
Chandler suggested I run this by you guys.
9 years, 4 months ago (2010-06-28 22:40:29 UTC) #1
DougGregor
9 years, 4 months ago (2010-06-29 14:54:41 UTC) #2
Looks good, please commit.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b