Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 1744046: More efficient way of adding content in RenderingGadgetRewriter#rewrite

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by janluehe
Modified:
15 years, 9 months ago
Reviewers:
henry.saputra, johnfargo, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Currently, RenderingGadgetRewriter#rewrite first removes any existing children of <head>, adds its own child nodes, and then adds back the previously removed children. This is not very efficient. This patch avoids removing and then adding back any existing children, by determining the first existing child node, if any, and then inserting any new nodes before it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java View 7 chunks +16 lines, -27 lines 0 comments Download

Messages

Total messages: 4
janluehe
15 years, 9 months ago (2010-07-06 21:37:33 UTC) #1
henry.saputra
LGTM
15 years, 9 months ago (2010-07-09 21:23:53 UTC) #2
johnfargo
LGTM On 2010/07/09 21:23:53, henry.saputra wrote: > LGTM
15 years, 9 months ago (2010-07-09 23:01:36 UTC) #3
henry.saputra
15 years, 9 months ago (2010-07-10 00:25:29 UTC) #4
Patch applied. Thanks Jan.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b