Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1491)

Issue 1743057: UAN Framework project (GSoC) final review

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by socket
Modified:
9 years ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Documentation extension and some fixes #

Patch Set 3 : Final patchset with test, docs, and merged with energy model #

Total comments: 15

Patch Set 4 : Added energy callbacks, energy depletion handling and test #

Patch Set 5 : Moved project's files to src/contrib/uan-framework, added manual chapter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -55 lines) Patch
A doc/manual/figures/auvmobility-classes.dia View Binary file 0 comments Download
M doc/manual/manual.texi View 2 chunks +2 lines, -0 lines 0 comments Download
A doc/manual/uan-framework.texi View 1 chunk +423 lines, -0 lines 0 comments Download
M examples/mobility/wscript View 1 3 1 chunk +1 line, -10 lines 0 comments Download
M src/contrib/energy/wscript View 1 3 4 2 chunks +0 lines, -14 lines 0 comments Download
M src/contrib/uan-framework/examples/auv-energy-model.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contrib/uan-framework/examples/auv-mobility.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/examples/li-ion-energy-source.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/contrib/uan-framework/examples/uan-energy-auv.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/examples/uan-energy-auv.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/examples/waypoint-mobility.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/contrib/uan-framework/examples/wscript View 1 chunk +17 lines, -0 lines 0 comments Download
M src/contrib/uan-framework/helper/acoustic-modem-energy-model-helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/contrib/uan-framework/helper/acoustic-modem-energy-model-helper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-glider-helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-glider-helper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-mobility-helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-mobility-helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-remus-helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/helper/auv-remus-helper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/acoustic-modem-energy-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/acoustic-modem-energy-model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contrib/uan-framework/model/auv-mobility-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/auv-mobility-model.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/glider-energy-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/glider-energy-model.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/contrib/uan-framework/model/glider-mobility-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/glider-mobility-model.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contrib/uan-framework/model/li-ion-energy-source.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/li-ion-energy-source.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/remus-energy-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/remus-energy-model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contrib/uan-framework/model/remus-mobility-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/remus-mobility-model.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contrib/uan-framework/model/simple-device-energy-model.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/model/simple-device-energy-model.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contrib/uan-framework/test/auv-energy-model-test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/contrib/uan-framework/test/auv-mobility-test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contrib/uan-framework/test/li-ion-energy-source-test.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A src/contrib/uan-framework/wscript View 1 chunk +40 lines, -0 lines 0 comments Download
M src/devices/uan/examples/wscript View 1 chunk +1 line, -7 lines 0 comments Download
M src/devices/uan/wscript View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/wscript View 1 3 2 chunks +0 lines, -6 lines 0 comments Download
M src/mobility/wscript View 1 3 2 chunks +0 lines, -7 lines 0 comments Download
M src/wscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
lentracy
I don't have much in the way of new comments on this code. I've made ...
9 years, 3 months ago (2010-08-09 05:49:47 UTC) #1
Tom Henderson
This looks nicely done in general. I had a few questions in the comments. - ...
9 years, 3 months ago (2010-08-14 22:27:11 UTC) #2
lentracy_u.washington.edu
Andrea, Were you able to respond to Tom's comments? I realize the coding portion is ...
9 years, 3 months ago (2010-08-17 03:13:25 UTC) #3
socket
http://codereview.appspot.com/1743057/diff/7001/8001 File examples/mobility/auv-energy-model.cc (right): http://codereview.appspot.com/1743057/diff/7001/8001#newcode65 examples/mobility/auv-energy-model.cc:65: DoubleValue (10000000)); On 2010/08/14 22:27:11, Tom Henderson wrote: > ...
9 years, 3 months ago (2010-08-17 17:02:11 UTC) #4
socket
http://codereview.appspot.com/1743057/diff/7001/src/contrib/energy/model/simple-device-energy-model.cc File src/contrib/energy/model/simple-device-energy-model.cc (right): http://codereview.appspot.com/1743057/diff/7001/src/contrib/energy/model/simple-device-energy-model.cc#newcode71 src/contrib/energy/model/simple-device-energy-model.cc:71: m_totalEnergyConsumption += energyToDecrease; The energy model starts by default ...
9 years, 2 months ago (2010-09-20 14:51:58 UTC) #5
socket
9 years, 2 months ago (2010-09-21 07:50:08 UTC) #6
socket
In patch set 4, I've addressed all the Tom's comments. I've changed the interaction between ...
9 years, 2 months ago (2010-09-21 10:01:40 UTC) #7
socket
9 years ago (2010-11-16 11:16:16 UTC) #8
socket
9 years ago (2010-11-16 11:23:21 UTC) #9
Patch Set 5 Highlights

- Moved all the project's files to src/contrib/uan-framework/
- Added manual draft documentation (UAN Framework chapter)
- Removed old includes
- Minor Doxygen changes
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b