Issue 1743054: Update party_vcarddav module for new Transaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1743054: Update party_vcarddav module for new Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by timitos

Modified:
15 years, 5 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : remove USER_ID and use parentheses instead of back slash #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -139 lines)			Patch
M	carddav.py	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	party.py	View		10 chunks	+35 lines, -47 lines	0 comments	Download
M	webdav.py	View	1	8 chunks	+71 lines, -85 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/1743054/diff/1/2 File carddav.py (right): http://codereview.appspot.com/1743054/diff/1/2#newcode45 carddav.py:45: res = collection_obj.get_address_data(int(USER_ID), dburi, Shoud remove USER_ID http://codereview.appspot.com/1743054/diff/1/4 File ...

15 years, 6 months ago (2010-08-03 20:31:14 UTC) #1

Ok for me

Expand All Messages | Collapse All Messages