update ldap_authentication module for new Transaction

[paepke, 2010-07-31 09:56:51]

http://codereview.appspot.com/1742053/diff/1/3
File res.py (right):

http://codereview.appspot.com/1742053/diff/1/3#newcode48
res.py:48: connection = connection_obj.browse(connection_ids[0])
i'm unsure about the change to remove the "0" next to cursor. it works only
without that "0".

[ced, 2010-07-31 10:38:28]

Must update INSTALL

http://codereview.appspot.com/1742053/diff/1/3
File res.py (right):

http://codereview.appspot.com/1742053/diff/1/3#newcode18
res.py:18: attrs=None):
attrs could be move up

http://codereview.appspot.com/1742053/diff/1/3#newcode48
res.py:48: connection = connection_obj.browse(connection_ids[0])
On 2010/07/31 09:56:51, paepke wrote:
> i'm unsure about the change to remove the "0" next to cursor. it works only
> without that "0".

You must use:

with Transaction.set_user(0):

http://codereview.appspot.com/1742053/diff/1/3#newcode60
res.py:60: con, connection, attrs=[]):
Can be on one line?

http://codereview.appspot.com/1742053/diff/1/3#newcode78
res.py:78: logins = [x.login for x in self.browse(user, ids2)]
user still there

http://codereview.appspot.com/1742053/diff/1/3#newcode82
res.py:82: def set_preferences(self, user_id, values, old_password=False):
user_id must be removed

http://codereview.appspot.com/1742053/diff/1/3#newcode86
res.py:86: connection_ids = connection_obj.search([], limit=1)
Must use set_user(0)

http://codereview.appspot.com/1742053/diff/1/3#newcode96
res.py:96: user = self.browse(user_id, user_id)
Must remove one user_id and replace the other by Transaction().user

http://codereview.appspot.com/1742053/diff/1/3#newcode97
res.py:97: [(dn, attrs)] = self.ldap_search_user(user_id,
Must remove user_id

http://codereview.appspot.com/1742053/diff/1/3#newcode113
res.py:113: connection_ids = connection_obj.search([], limit=1)
Must use set_user(0)

http://codereview.appspot.com/1742053/diff/1/3#newcode124
res.py:124: con, connection, attrs=[str(connection.auth_uid)])
Can be re-indented

[paepke, 2010-08-01 21:54:07]

http://codereview.appspot.com/1742053/diff/1/3
File res.py (right):

http://codereview.appspot.com/1742053/diff/1/3#newcode18
res.py:18: attrs=None):
On 2010/07/31 10:38:28, ced wrote:
> attrs could be move up

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode48
res.py:48: connection = connection_obj.browse(connection_ids[0])
On 2010/07/31 10:38:28, ced wrote:
> On 2010/07/31 09:56:51, paepke wrote:
> > i'm unsure about the change to remove the "0" next to cursor. it works only
> > without that "0".
> 
> You must use:
> 
> with Transaction.set_user(0):

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode60
res.py:60: con, connection, attrs=[]):
On 2010/07/31 10:38:28, ced wrote:
> Can be on one line?

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode78
res.py:78: logins = [x.login for x in self.browse(user, ids2)]
On 2010/07/31 10:38:28, ced wrote:
> user still there

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode82
res.py:82: def set_preferences(self, user_id, values, old_password=False):
On 2010/07/31 10:38:28, ced wrote:
> user_id must be removed

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode86
res.py:86: connection_ids = connection_obj.search([], limit=1)
On 2010/07/31 10:38:28, ced wrote:
> Must use set_user(0)

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode96
res.py:96: user = self.browse(user_id, user_id)
On 2010/07/31 10:38:28, ced wrote:
> Must remove one user_id and replace the other by Transaction().user

Done.

http://codereview.appspot.com/1742053/diff/1/3#newcode97
res.py:97: [(dn, attrs)] = self.ldap_search_user(user_id,
On 2010/07/31 10:38:28, ced wrote:
> Must remove user_id

Done.

[ced, 2010-08-02 08:36:48]

http://codereview.appspot.com/1742053/diff/1/3
File res.py (right):

http://codereview.appspot.com/1742053/diff/1/3#newcode60
res.py:60: con, connection, attrs=[]):
On 2010/08/01 21:54:07, paepke wrote:
> On 2010/07/31 10:38:28, ced wrote:
> > Can be on one line?
> 
> Done.

It is not.

http://codereview.appspot.com/1742053/diff/3002/5003#newcode85
res.py:85: if 'password' in values:
user_id is only used one time. So it is more readable to put it there.

http://codereview.appspot.com/1742053/diff/3002/5003#newcode109
res.py:109: old_password=old_password)
wrong user_id

[paepke, 2010-08-02 12:28:33]

http://codereview.appspot.com/1742053/diff/3002/5003
File res.py (right):

http://codereview.appspot.com/1742053/diff/3002/5003#newcode85
res.py:85: user_id = Transaction().user
On 2010/08/02 08:36:49, ced wrote:
> user_id is only used one time. So it is more readable to put it there.
tried to keep up with res/user.py to have it a little bit compareable.

[ced, 2010-08-02 17:59:59]

Ok for me

[paepke, 2010-08-12 20:20:17]

On 2010/08/02 17:59:59, ced wrote:
> Ok for me

no report patch needed