Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 1741060: Fix for issue 1173 to fails when asked to showLastLength on partial measures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Neil Puttock
Modified:
3 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org, MikeSol
Visibility:
Public.

Description

Fix for issue 1173 to fails when asked to showLastLength on partial measures.

Fixes 1173 no error message rounds up to the next measure

Patch from Mike Solomon.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -25 lines) Patch
M scm/define-woodwind-diagrams.scm View 1 chunk +0 lines, -13 lines 0 comments Download
M scm/lily-library.scm View 2 chunks +21 lines, -1 line 0 comments Download
M scm/music-functions.scm View 5 chunks +123 lines, -11 lines 4 comments Download

Messages

Total messages: 2
Neil Puttock
Hi Mike, Here are some general comments following testing: -) showFirstLength still doesn't work -) ...
3 years, 8 months ago #1
Neil Puttock
3 years, 8 months ago #2
http://codereview.appspot.com/1741060/diff/1/4
File scm/music-functions.scm (right):

http://codereview.appspot.com/1741060/diff/1/4#newcode534
scm/music-functions.scm:534: (set! (ly:music-property m 'den) den)
These should come from the music (which means you'll be needing a fix for issue
#1198: \time requires a synthetic music object to generate the context property
settings).

We already have two music properties called `numerator' and `denominator' which
could be used (it even appears that they might originally have had this purpose,
judging by the docstrings, even though they're currently used for \times)

http://codereview.appspot.com/1741060/diff/1/4#newcode932
scm/music-functions.scm:932: (define (generate-timing-alist music)
needs a docstring

(+ others below)

http://codereview.appspot.com/1741060/diff/1/4#newcode936
scm/music-functions.scm:936: (define (time-helper music)
Following a fix for #1198, this could be simplified

http://codereview.appspot.com/1741060/diff/1/4#newcode1035
scm/music-functions.scm:1035: (integrated-measures
This looks rather costly, since it will be called for all scores, even if
show(First|Last)Length isn't set (skip-as-needed is a top-level music function,
so it's applied automatically whenever the parser encounters music)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1274:9b9295c7fd64