Issue 174083: code review 174083: pkg/xml: handle unexpected EOF while parsing and fix a ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 174083: code review 174083: pkg/xml: handle unexpected EOF while parsing and fix a ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by art

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

pkg/xml: handle unexpected EOF while parsing and fix a bug in name() mustgetc() reports unexpected EOF as SyntaxError. using mustgetc() seems to be a better approach than letting the caller handle unexpected EOF every time. name(): the second if statement should explicitly return ok==false.

Patch Set 1 #

Patch Set 2 : code review 174083: pkg/xml: handle unexpected EOF while parsing and fix a ... #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -27 lines)			Patch
	M	src/pkg/xml/xml.go	View		14 chunks	+41 lines, -27 lines	0 comments	Download
	M	src/pkg/xml/xml_test.go	View		2 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

14 years, 5 months ago (2009-12-15 03:28:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2701d4abb3f2 ***

xml: handle unexpected EOF while parsing and fix a bug in name

mustgetc reports unexpected EOF as SyntaxError.  using
mustgetc seems to be a better approach than letting the
caller handle unexpected EOF every time.

name: the second if statement should explicitly return
ok==false.

R=rsc
http://codereview.appspot.com/174083

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages