Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(663)

Issue 174082: code review 174082: fix bug for large counts: used a one-byte buffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by r
Modified:
14 years, 4 months ago
Reviewers:
cw
CC:
rsc, golang-dev_googlegroups.org
Visibility:
Public.

Description

fix bug for large counts: used a one-byte buffer.

Patch Set 1 #

Patch Set 2 : code review 174082: fix bug for large counts: used a one-byte buffer. #

Patch Set 3 : code review 174082: fix bug for large counts: used a one-byte buffer. #

Patch Set 4 : code review 174082: fix bug for large counts: used a one-byte buffer. #

Patch Set 5 : code review 174082: fix bug for large counts: used a one-byte buffer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/pkg/gob/decoder.go View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-dev@googlegroups.org), I'd like you to review the following change.
14 years, 4 months ago (2009-12-12 19:57:30 UTC) #1
rsc
LGTM
14 years, 4 months ago (2009-12-12 20:19:06 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=491b7802d110 *** fix bug for large counts: used a one-byte buffer. R=rsc ...
14 years, 4 months ago (2009-12-12 20:27:50 UTC) #3
cw
> fix bug for large counts: used a one-byte buffer. i'm curious --- why 9 ...
14 years, 4 months ago (2009-12-13 01:55:46 UTC) #4
r2
14 years, 4 months ago (2009-12-13 02:19:23 UTC) #5
On 13/12/2009, at 12:55 PM, cw@f00f.org wrote:

>> fix bug for large counts: used a one-byte buffer.
>
> i'm curious --- why 9 now and not 8?
>
>
> http://codereview.appspot.com/174082

the encoding used by gobs takes 9 bytes to represent an 8-byte integer.

-rob

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b