Issue 174076: code review 174076: Various cleanups:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 174076: code review 174076: Various cleanups: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by gri

Modified:
15 years, 3 months ago

Reviewers:
rsc

Visibility:
Public.

Description

Various cleanups: - no need to replace comments for stand-alone blocks - always print string concatenations with interspersed "+" (remove option) - minor cleanups

Patch Set 2 : code review 174076: Various cleanups: #

Total comments: 1

Patch Set 3 : code review 174076: Various cleanups: #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -24 lines)			Patch
M	src/cmd/gofmt/gofmt.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	11 chunks	+16 lines, -20 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/testing/regexp.go	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

LGTM http://codereview.appspot.com/174076/diff/10/1002 File src/pkg/go/printer/nodes.go (right): http://codereview.appspot.com/174076/diff/10/1002#newcode20 src/pkg/go/printer/nodes.go:20: compositeLitBlank = false; i think we decided not ...

15 years, 3 months ago (2009-12-12 00:26:44 UTC) #2

gri

On Fri, Dec 11, 2009 at 4:26 PM, <rsc@golang.org> wrote: > LGTM > > > ...

15 years, 3 months ago (2009-12-12 00:42:01 UTC) #3

gri

15 years, 3 months ago (2009-12-12 00:42:16 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e7f3b2a4d933 ***

Various cleanups:
- no need to replace comments for stand-alone blocks
- always print string concatenations with interspersed "+"
  (remove option)
- minor cleanups

R=rsc
http://codereview.appspot.com/174076

Expand All Messages | Collapse All Messages