Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 174072: code review 174072: codereview: add golang-dev@googlegroups.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by rsc
Modified:
15 years, 3 months ago
Reviewers:
CC:
gri, cw, golang-dev
Visibility:
Public.

Description

codereview: add golang-dev@googlegroups.com automatically in "hg mail". also, avoid "empty list means all modified files in client" bug

Patch Set 1 #

Patch Set 2 : code review 174072: codereview: add golang-dev@googlegroups.com #

Patch Set 3 : code review 174072: codereview: add golang-dev@googlegroups.com #

Patch Set 4 : code review 174072: codereview: add golang-dev@googlegroups.com #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -40 lines) Patch
M lib/codereview/codereview.py View 1 2 3 12 chunks +33 lines, -40 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 3 months ago (2009-12-11 21:34:58 UTC) #1
gri
LGTM On Fri, Dec 11, 2009 at 1:34 PM, <rsc@golang.org> wrote: > Reviewers: gri, > ...
15 years, 3 months ago (2009-12-11 21:50:01 UTC) #2
cw
> > codereview: add mailto:golang-dev@googlegroups.com > > automatically in "hg mail". > > also, avoid ...
15 years, 3 months ago (2009-12-11 22:53:32 UTC) #3
rsc
15 years, 3 months ago (2009-12-15 21:36:09 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=885bb5701b4c ***

codereview: add golang-dev@googlegroups.com
    automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug

R=gri, cw
CC=golang-dev
http://codereview.appspot.com/174072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b