Issue 1740045: code review 1740045: factor common prefixes from alternations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1740045: code review 1740045: factor common prefixes from alternations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

factor common prefixes from alternations Juggle code so that RE2::Set can benefit too.

Patch Set 1 #

Patch Set 2 : code review 1740045: factor common prefixes from alternations #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+654 lines, -194 lines)			Patch
M	re2/compile.cc	View	13 chunks	+37 lines, -37 lines	0 comments	Download
M	re2/mimics_pcre.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	re2/parse.cc	View	17 chunks	+193 lines, -58 lines	0 comments	Download
M	re2/prog.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	re2/prog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	re2/regexp.h	View	8 chunks	+83 lines, -36 lines	0 comments	Download
M	re2/regexp.cc	View	8 chunks	+192 lines, -8 lines	0 comments	Download
M	re2/set.cc	View	4 chunks	+40 lines, -16 lines	0 comments	Download
M	re2/simplify.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	re2/testing/compile_test.cc	View	1 chunk	+18 lines, -18 lines	0 comments	Download
M	re2/testing/dump.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	re2/testing/parse_test.cc	View	4 chunks	+35 lines, -10 lines	0 comments	Download
M	re2/testing/set_test.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	re2/testing/simplify_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	re2/tostring.cc	View	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-07-16 03:38:03 UTC) #1

rsc

15 years ago (2010-07-16 03:38:08 UTC) #2

*** Submitted as http://code.google.com/p/re2/source/detail?r=1fe8927b19db ***

factor common prefixes from alternations

Juggle code so that RE2::Set can benefit too.

R=rsc
CC=re2-dev
http://codereview.appspot.com/1740045

Expand All Messages | Collapse All Messages