Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2418)

Issue 17400043: Update cpplint.py to #267: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by erg
Modified:
11 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
Mark Mentovai
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update cpplint.py to #267: - Handle parentheses in CHECK() calls properly. - Fixed multiple false positives where various things like std::fucntion<> or function pointers were being mistaken for casts. - Fixed whitespace warning on placement new. - Fixed multiple false positives related to const references. - Added warning for empty conditional bodies. - Stop advising the use of readdir_r instead of readdir. - Fixed false positive for empty macro arguments. - Fixed false positvie for braced initializer lists. - Don't warn about unnamed parameters in function pointers. R=mark@chromium.org Committed: https://code.google.com/p/google-styleguide/source/detail?r=114

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -236 lines) Patch
M cpplint/cpplint.py View 1 25 chunks +334 lines, -208 lines 0 comments Download
M cpplint/cpplint_unittest.py View 12 chunks +106 lines, -28 lines 0 comments Download

Messages

Total messages: 3
erg
Part 2 of trying to clear the backlog.
11 years, 1 month ago (2013-10-25 21:41:29 UTC) #1
Mark Mentovai
OK, LGTM
11 years, 1 month ago (2013-10-25 21:43:31 UTC) #2
erg
11 years, 1 month ago (2013-10-25 21:44:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r114 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b