Issue 1733043: Set a default SERVER_PORT variable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1733043: Set a default SERVER_PORT variable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by Paul Lindner

Modified:
15 years, 7 months ago

Reviewers:
zhoresh, dev-remailer

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -9 lines)			Patch
M	config/container.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java	View	2 chunks	+16 lines, -2 lines	1 comment	Download
M	java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigTest.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ConcatProxyServletTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

zhoresh

15 years, 9 months ago (2010-06-25 00:55:22 UTC) #2

lgtm, just one nit

http://codereview.appspot.com/1733043/diff/1/4
File
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java
(right):

http://codereview.appspot.com/1733043/diff/1/4#newcode205
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java:205:
System.out.println("%% Converting " + key);
Maybe remove this?

Expand All Messages | Collapse All Messages