Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 173280043: widen multimeasure rests with numbers

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Keith
Modified:
9 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

multi-measure-rest: give space according to duration Revert part of 61ae62f987 Code to space spanners should apply 'bound-padding', but not 'padding'.

Patch Set 1 #

Patch Set 2 : space multimeasure rests according to the full duration #

Patch Set 3 : variable widening of long rests #

Total comments: 1

Patch Set 4 : entry in changes.tely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M Documentation/changes.tely View 1 chunk +8 lines, -0 lines 0 comments Download
M lily/multi-measure-rest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 1
lemzwerg
9 years, 4 months ago (2014-11-27 09:33:15 UTC) #1
LGTM, save a small remark.

https://codereview.appspot.com/173280043/diff/40001/scm/define-grob-propertie...
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/173280043/diff/40001/scm/define-grob-propertie...
scm/define-grob-properties.scm:1287: containing a multimeasure rest, per factor
of two in its duration.")
I've seen the code, so I understand this sentence.  However, I think that other
people will stumble...  Can you reformulate this to be more verbose?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b