code review 172045: missed a couple of files in test

missed a couple of files in test

[gri, 2009-12-10 03:35:35]

Hello rsc (cc: r),

I'd like you to review the following change.

[r, 2009-12-10 03:42:39]

LGTM

http://codereview.appspot.com/172045/diff/1/2
File test/chan/powser2.go (left):

http://codereview.appspot.com/172045/diff/1/2#oldcode572
test/chan/powser2.go:572: if end(get(VV[0])) != 0 { put(finis,Z); }
just for the record, there's nothing wrong with just deleting the semicolon in
these cases.  these rewrites are fine and probably good but unnecessary.

[gri, 2009-12-10 05:37:47]

The issue is that a semicolon is inserted after a } at the end of a line
which in this case detaches the else keyword from the if statement and
causes a syntax error. A rewrite is necessary for these programs to be
accepted with the new syntax.

At this point all code (except possibly some files under test/bugs and
test/fixedbugs, and a lot of files under test/ken) should be accepted by
both the old and new syntax.

- Robert

On Wed, Dec 9, 2009 at 7:42 PM, <r@golang.org> wrote:

> LGTM
>
>
> http://codereview.appspot.com/172045/diff/1/2
> File test/chan/powser2.go (left):
>
> http://codereview.appspot.com/172045/diff/1/2#oldcode572
> test/chan/powser2.go:572: if end(get(VV[0])) != 0 { put(finis,Z); }
> just for the record, there's nothing wrong with just deleting the
> semicolon in these cases.  these rewrites are fine and probably good but
> unnecessary.
>
>
> http://codereview.appspot.com/172045
>

[gri, 2009-12-10 05:39:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=ef74204c7ba7 ***

missed a couple of files in test

R=rsc, r
http://codereview.appspot.com/172045

[rsc, 2009-12-10 06:02:41]

we could always rename else to "if not".

if x < y {
    ...
}
if not {
   ...
}

as in the plan 9 shell rc.

[r2, 2009-12-10 06:05:43]

right

if x { a = b } else { a = c }

that works, though. the whole thing must be one line