Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 1715049: SHINDIG-1378: Caja removes unknown attributes in os:PeopleSelector (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by chirag
Modified:
15 years, 7 months ago
Reviewers:
dev-remailer, Jasvir
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

The os:PeopleSelector tag definition generates the following attributes in the select tag which are stripped by Caja: x-var x-max x-onselect The fix is to move this data into the constructor. Messages from Caja: stdin:stdin:62: elect" onchange="os_PeopleSelector_onchange(this)" x-max="2" x-onselect="" x-var WARNING: stdin:stdin:62+123 - 128: removing unknown attribute x-var on select stdin:stdin:62: ="peopleSelect" onchange="os_PeopleSelector_onchange(this)" x-max="2" x-onselect WARNING: stdin:stdin:62+109 - 119: removing unknown attribute x-onselect on select stdin:stdin:62: "multiple" name="peopleSelect" onchange="os_PeopleSelector_onchange(this)" x-max WARNING: stdin:stdin:62+99 - 104: removing unknown attribute x-max on select Caja Issue: http://code.google.com/p/google-caja/issues/detail?id=933 JIRA: https://issues.apache.org/jira/browse/SHINDIG-1378

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix issues with quoting parameters found by Felix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
config/OSML_library.xml View 2 3 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 4
chirag
15 years, 8 months ago (2010-07-15 19:39:12 UTC) #1
chirag
15 years, 8 months ago (2010-07-15 22:27:55 UTC) #2
chirag
Fix issues with quoting parameters found by Felix
15 years, 8 months ago (2010-07-16 20:32:02 UTC) #3
Jasvir
15 years, 8 months ago (2010-07-16 21:01:55 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b