Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1248)

Side by Side Diff: doc/contribute.html

Issue 171048: Add a Makefile in place of all.bash (Closed)
Patch Set: code review 171048: Add a Makefile in place of all.bash. Update docs to reflect Created 15 years, 3 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « doc/code.html ('k') | doc/install.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!-- Contributing to the Go project --> 1 <!-- Contributing to the Go project -->
2 2
3 <h2 id="Introduction">Introduction</h2> 3 <h2 id="Introduction">Introduction</h2>
4 4
5 <p> 5 <p>
6 This document explains how to contribute changes to the Go project. 6 This document explains how to contribute changes to the Go project.
7 It assumes you have installed Go using the 7 It assumes you have installed Go using the
8 <a href="install.html">installation instructions</a> and 8 <a href="install.html">installation instructions</a> and
9 have <a href="code.html">written and tested your code</a>. 9 have <a href="code.html">written and tested your code</a>.
10 (Note that the <code>gccgo</code> frontend lives elsewhere; 10 (Note that the <code>gccgo</code> frontend lives elsewhere;
11 see <a href="gccgo_contribute.html">Contributing to gccgo</a>.) 11 see <a href="gccgo_contribute.html">Contributing to gccgo</a>.)
12 </p> 12 </p>
13 13
14 <h2 id="Testing">Testing redux</h2> 14 <h2 id="Testing">Testing redux</h2>
15 15
16 <p> 16 <p>
17 You've <a href="code.html">written and tested your code</a>, but 17 You've <a href="code.html">written and tested your code</a>, but
18 before sending code out for review, run all the tests for the whole 18 before sending code out for review, run all the tests for the whole
19 tree to make sure the changes don't break other packages or programs: 19 tree to make sure the changes don't break other packages or programs:
20 </p> 20 </p>
21 21
22 <pre> 22 <pre>
23 cd $GOROOT/src 23 cd $GOROOT/src
24 ./all.bash 24 make all
25 </pre> 25 </pre>
26 26
27 <p> 27 <p>
28 The final line printed by <code>all.bash</code> should be of the form: 28 The final line printed by <code>make all</code> should be of the form:
29 </p> 29 </p>
30 30
31 <pre> 31 <pre>
32 <i>N</i> known bugs; 0 unexpected bugs 32 <i>N</i> known bugs; 0 unexpected bugs
33 </pre> 33 </pre>
34 34
35 <p> 35 <p>
36 The value of <i>N</i> varies over time, but the line must 36 The value of <i>N</i> varies over time, but the line must
37 say &ldquo;<code>0 unexpected bugs</code>&rdquo; and must not 37 say &ldquo;<code>0 unexpected bugs</code>&rdquo; and must not
38 add &ldquo;<code>test output differs</code>.&rdquo; 38 add &ldquo;<code>test output differs</code>.&rdquo;
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 This rigmarole needs to be done only for your first submission. 498 This rigmarole needs to be done only for your first submission.
499 </p> 499 </p>
500 500
501 <p>Code that you contribute should use the standard copyright header:</p> 501 <p>Code that you contribute should use the standard copyright header:</p>
502 502
503 <pre> 503 <pre>
504 // Copyright 2009 The Go Authors. All rights reserved. 504 // Copyright 2009 The Go Authors. All rights reserved.
505 // Use of this source code is governed by a BSD-style 505 // Use of this source code is governed by a BSD-style
506 // license that can be found in the LICENSE file. 506 // license that can be found in the LICENSE file.
507 </pre> 507 </pre>
OLDNEW
« no previous file with comments | « doc/code.html ('k') | doc/install.html » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b