Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(492)

Issue 1705043: Converting private fields to protected for ease of extending (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by gagan.goku
Modified:
15 years, 8 months ago
Reviewers:
johnfargo, zhoresh, shindig.remailer, dev-remailer
CC:
cool-shindig-committers_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Converting private final requestPipeline, responseRewriterRegistry and uriManager to protected so that it is easy to override them when extending HtmlAccelServlet.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing_comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
zhoresh
http://codereview.appspot.com/1705043/diff/1/2 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1705043/diff/1/2#newcode59 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:59: protected AccelUriManager uriManager; Maybe keep them final, and override ...
15 years, 8 months ago (2010-06-21 20:51:03 UTC) #1
gagan.goku
On 2010/06/21 20:51:03, zhoresh wrote: > http://codereview.appspot.com/1705043/diff/1/2 > File > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java > (right): > > ...
15 years, 8 months ago (2010-06-21 20:57:00 UTC) #2
gagan.goku
http://codereview.appspot.com/1705043/diff/1/2 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1705043/diff/1/2#newcode59 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:59: protected AccelUriManager uriManager; On 2010/06/21 20:51:04, zhoresh wrote: > ...
15 years, 8 months ago (2010-06-21 20:57:09 UTC) #3
zhoresh
lgtm, committed (r956695)
15 years, 8 months ago (2010-06-21 21:09:27 UTC) #4
gagan.goku
15 years, 8 months ago (2010-06-21 21:10:45 UTC) #5
On 2010/06/21 21:09:27, zhoresh wrote:
> lgtm, committed (r956695)

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b