Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(186)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
1704045
: Check the correct attribute of OAuthErrors
Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by
jtarrio
Modified:
15 years, 8 months ago
Reviewers:
zhoresh
, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.
Description
Without this patch, all OAuthErrors get logged as Warning, instead of having some logged as Info.
Patch Set 1
#
Created:
15 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+2 lines, -2 lines
)
Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
View
1 chunk
+2 lines, -2 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
jtarrio
15 years, 8 months ago (2010-07-01 19:06:04 UTC)
#1
Sign in
to reply to this message.
zhoresh
lgtm, basically use the correct error name in comparison Committing
15 years, 8 months ago (2010-07-01 19:16:27 UTC)
#2
lgtm, basically use the correct error name in comparison Committing
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 1704045: Check the correct attribute of OAuthErrors
Created 15 years, 8 months ago by jtarrio
Modified 15 years, 8 months ago
Reviewers: zhoresh, shindig.remailer_gmail.com
Base URL: http://svn.apache.org/repos/asf/shindig/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b